ianmcook commented on a change in pull request #12435:
URL: https://github.com/apache/arrow/pull/12435#discussion_r810225571
##########
File path: r/R/dplyr-count.R
##########
@@ -25,12 +25,13 @@ count.arrow_dplyr_query <- function(x, ..., wt = NULL, sort
= FALSE, name = NULL
}
out <- dplyr::tally(out, wt = {{ wt }}, sort = sort, name = name)
- # Restore original group vars
gv <- dplyr::group_vars(x)
- if (length(gv)) {
+ if (rlang::is_empty(gv)) {
Review comment:
Thanks for this! For rlang functions, we prefer to import them so we
don't have to use `rlang::`. Could you please add `is_empty` in to the imported
rlang functions in
[`arrow-package.R`](https://github.com/apache/arrow/blob/ade1027c3f6711374c6ccccff5ce068e0476664d/r/R/arrow-package.R#L22-L26),
remove the `rlang::` here, and run `devtools::document()`? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
