gsserge opened a new pull request #1342:
URL: https://github.com/apache/arrow-rs/pull/1342


   # Which issue does this PR close?
   
   Closes issue https://github.com/apache/arrow-rs/issues/1328.
   
   I think that I wrote the issue above in a bit of a rush, the part about 
changes to `Writer::new()`. The doc comment for `Writer::new()` clearly states 
that a new CsvWriter is initialized with default options, with `,` being the 
default delimiter.
   
   A custom delimiter can be configured using already existing 
`WriterBuilder::with_delimiter`. So, in my view, the scope of the issue is to 
simply remove unused code without any changes to the API.
   
   # Rationale for this change
   
   There is no use for the `delimiter` field in csv `Writer`.
   
   # What changes are included in this PR?
   
   The unused `delimiter` field is removed.
   
   # Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to