Alfred-Mountfield commented on pull request #12451:
URL: https://github.com/apache/arrow/pull/12451#issuecomment-1046288157


   >Since you have a local test case, please add a unit test so we can ensure 
not to repeat this issue.
   
   @domoritz 
   The local code that exposes the issue is a system that uses both the Rust 
Arrow implementation and the JavaScript implementation. I actually am not 100% 
sure how to write a unit-test for this within this repository. 
   
   The problem goes a bit deeper, as I've raised in a different [Jira 
ticket](https://issues.apache.org/jira/browse/ARROW-15651), and I'm afraid I'm 
nowhere near familiar enough with the implementation within this repository to 
be able to contribute effectively at this point. I have found it difficult to 
understand the correct way of doing things with this package, as the docs are 
less beginner-friendly than the other language implementations, and the lack of 
examples exacerbates this.
   
   I'm open to trying to contribute further, but I do not know how much time I 
can allocate to learning the specifics of this implementation (hence me missing 
the purposes of the `setValid` method). I did have a look around the testing 
for the builders and such but there seems to be a rather complex technique to 
generating test cases which would take a while to understand how to expand it 
to cover these quite specific edge-cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to