dragosmg commented on a change in pull request #12433:
URL: https://github.com/apache/arrow/pull/12433#discussion_r811045008
##########
File path: r/R/dplyr-funcs-datetime.R
##########
@@ -147,5 +147,7 @@ register_bindings_datetime <- function() {
register_binding("pm", function(x) {
!call_binding("am", x)
})
-
+ register_binding("date", function(x) {
+ x$cast(date32())
+ })
Review comment:
Q2: Not sure what we want to achieve by calling a binding (in this case
`"date"`) on an R object. Do we want to support this (should all bindings
support R objects as inputs?) or do we just want to make sure the error message
is meaningful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
