pitrou commented on a change in pull request #11982:
URL: https://github.com/apache/arrow/pull/11982#discussion_r811320485
##########
File path: format/FlightSql.proto
##########
@@ -867,6 +867,185 @@ enum SqlSupportsConvert {
SQL_CONVERT_VARCHAR = 19;
}
+/**
+ * It is an attribute that identifies the type of any object. It's
+ * used by JDBC and ODBC to expose the values defined by the DBMC.
+ */
+enum XDBCDataType {
+ XDBC_TYPE_UNKNOWN_TYPE = 0;
+ XDBC_TYPE_CHAR = 1;
+ XDBC_TYPE_NUMERIC = 2;
+ XDBC_TYPE_DECIMAL = 3;
+ XDBC_TYPE_INTEGER = 4;
+ XDBC_TYPE_SMALLINT = 5;
+ XDBC_TYPE_FLOAT = 6;
+ XDBC_TYPE_REAL = 7;
+ XDBC_TYPE_DOUBLE = 8;
+ XDBC_TYPE_DATETIME = 9;
+ XDBC_TYPE_INTERVAL = 10;
+ XDBC_TYPE_VARCHAR = 12;
+ XDBC_LONGVARCHAR = -1;
+ XDBC_BINARY = -2;
+ XDBC_VARBINARY = -3;
+ XDBC_LONGVARBINARY = -4;
+ XDBC_BIGINT = -5;
+ XDBC_TINYINT = -6;
+ XDBC_BIT = -7;
+ XDBC_WCHAR = -8;
+ XDBC_WVARCHAR = -9;
Review comment:
I'm curious: is there a reason some types have negative values? Also,
the naming is a bit inconsistent (`XDBC_TYPE_something` vs. `XDBC_something`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
