cyb70289 commented on a change in pull request #12426:
URL: https://github.com/apache/arrow/pull/12426#discussion_r811530024
##########
File path: cpp/src/arrow/csv/writer_test.cc
##########
@@ -171,6 +173,13 @@ std::vector<WriterTestParams> GenerateTestCases() {
"style is \"None\". See RFC4180. Invalid value: ",
value);
};
+
+ auto expected_status_illegal_delimiter = [](const char value) {
+ return Status::Invalid(
+ "WriteOptions: delimiter cannot be \\r or \\n or \" or EOL. Invalid
value: ",
+ value);
+ };
Review comment:
Better to move it under line 205 together with delimiter tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
