jonkeane commented on pull request #12240: URL: https://github.com/apache/arrow/pull/12240#issuecomment-1047830063
> I am convinced the errors we are seeing on Windows are due to the interaction between this PR and [ARROW-13168](https://issues.apache.org/jira/browse/ARROW-13168). We define the datetime column of our test data frame with an empty ("") timezone which effectively forces (as is the objective of this PR) a use of the system timezone, which on Windows cannot be found. Would the tests work if we change that chunk to: ``` # TODO: We should test on windows once ARROW-13168 is resolved. if (tolower(Sys.info()[["sysname"]]) == "windows") { test_date <- as.POSIXct("2017-01-01 00:00:11.3456789") } else { test_date <- as.POSIXct("2017-01-01 00:00:11.3456789", tz = "Pacific/Marquesas") } ``` What I want to make sure we don't do is that we don't introduce a situation where this PR causes an error on windows when someone calls `Array$create(as.POSIXct("2017-01-01 00:00:11.3456789"))` or some other code to convert a timestamp into an arrow object on windows when we don't (currently) error now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
