jonkeane commented on a change in pull request #12431:
URL: https://github.com/apache/arrow/pull/12431#discussion_r812023897
##########
File path: r/tests/testthat/test-dplyr-funcs-datetime.R
##########
@@ -712,6 +712,7 @@ test_that("am/pm mirror lubridate", {
})
+
Review comment:
```suggestion
```
##########
File path: r/tests/testthat/test-dplyr-funcs-datetime.R
##########
@@ -747,5 +748,43 @@ test_that("extract tz", {
expect_error(
call_binding("tz", Expression$scalar("2020-10-01")),
"timezone extraction for objects of class `string` not supported in Arrow"
+ )
+ })
+
+test_that("dst extracts daylight savings time correctly", {
+ test_df <- tibble(
+ dates = as.POSIXct(c("2021-02-20", "2021-07-31", "2021-10-31",
"2021-01-31"), tz = "Europe/London")
+ )
+ # https://issues.apache.org/jira/browse/ARROW-13168
+ skip_on_os("windows")
+
+ compare_dplyr_binding(
+ .input %>%
+ mutate(dst = dst(dates)) %>%
+ collect(),
+ test_df
+ )
+})
+
+test_that("dst errors with unsupported input", {
+ expect_error(
+ call_function("is_dst", Scalar$create("this is a string, not a
timestamp")),
+ "NotImplemented: Function 'is_dst' has no kernel matching input types
(scalar[string])",
+ fixed = TRUE
+ )
+ expect_error(
+ call_function("is_dst", Scalar$create(1L)),
+ "NotImplemented: Function 'is_dst' has no kernel matching input types
(scalar[int32])",
+ fixed = TRUE
+ )
+ expect_error(
+ call_function("is_dst", Scalar$create(2.2)),
+ "NotImplemented: Function 'is_dst' has no kernel matching input types
(scalar[double])",
+ fixed = TRUE
+ )
+ expect_error(
+ call_function("is_dst", Scalar$create(TRUE)),
+ "NotImplemented: Function 'is_dst' has no kernel matching input types
(scalar[bool])",
+ fixed = TRUE
Review comment:
Since these are all basically testing C++ only, let's remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
