jonkeane commented on a change in pull request #12319:
URL: https://github.com/apache/arrow/pull/12319#discussion_r812326009
##########
File path: r/R/dplyr-funcs-datetime.R
##########
@@ -140,3 +140,22 @@ register_bindings_datetime <- function() {
(year %% 4 == 0) & ((year %% 100 != 0) | (year %% 400 == 0))
})
}
+
+binding_format_datetime <- function(x, format = "", tz = "", usetz = FALSE) {
+ if (usetz) {
+ format <- paste(format, "%Z")
+ }
+
+ if (call_binding("is.POSIXct", x)) {
+ if (tz == "" && x$type()$timezone() != "") {
+ tz <- x$type()$timezone()
+ } else if (tz == "") {
+ tz <- Sys.timezone()
+ }
Review comment:
Would some of this stuff change when #12240 merges? If so, we should add
a note here that we should revisit this behavior when that merges
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
