kszucs commented on pull request #12322: URL: https://github.com/apache/arrow/pull/12322#issuecomment-1048523391
> > This removal of git was added in #10342, cc @kszucs > > @kszucs do you remember the reason for it? Git was used to generate a version number even for a python sdist release with explicit version and already available source code. > We now have a similar failure of the `python-sdist` build, this time the new substrait option requiring git: > > ``` > CMake Error at /usr/share/cmake-3.16/Modules/ExternalProject.cmake:2421 (message): > error: could not find git for clone of substrait_ep > Call Stack (most recent call first): > /usr/share/cmake-3.16/Modules/ExternalProject.cmake:3236 (_ep_add_download_command) > src/arrow/engine/CMakeLists.txt:50 (externalproject_add) > ``` I think we should avoid hard dependency on git and prefer downloading tarballs from github. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
