westonpace commented on pull request #12408: URL: https://github.com/apache/arrow/pull/12408#issuecomment-1049117504
I've made an attempt at addressing the PR feedback in preparation for the OT release. This should be pretty close to what we will use (I think only two lines will change once we can use their new API). The unit test is a little unreliable. If I run it on repeat I can trigger the failure much more reliably than running it a single time. I played around with a few different approaches but couldn't come up with a variation that failed very reliably. I'm not sure if we want to leave it in or just get rid of it and rely on catching this via TSAN were there to be a regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
