jorisvandenbossche commented on a change in pull request #12507:
URL: https://github.com/apache/arrow/pull/12507#discussion_r814207210
##########
File path: python/pyarrow/tests/test_compute.py
##########
@@ -2032,6 +2032,11 @@ def _check_temporal_rounding(ts, values, unit):
expected = ts.dt.round(frequency)
np.testing.assert_array_equal(result, expected)
+ # Check RoundTemporalOptions defaults
+ result = pc.round_temporal(ta).to_pandas()
Review comment:
Note that this doesn't fully test the the fixed bug, as the above
already worked correctly on master. It's when specifying "some" option, that
the python option class gets used, and thus their defaults. So eg doing
`pc.round_temporal(ta, multiple=1)` would test it (because then it uses the
default "day" of the python option class)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
