jcralmeida commented on a change in pull request #11982:
URL: https://github.com/apache/arrow/pull/11982#discussion_r814910637
##########
File path:
java/flight/flight-sql/src/test/java/org/apache/arrow/flight/sql/example/FlightSqlExample.java
##########
@@ -433,6 +483,52 @@ private static VectorSchemaRoot getRoot(final ResultSet
data, final BufferAlloca
return new VectorSchemaRoot(singletonList(dataVector));
}
+ private static VectorSchemaRoot getTypeInfoRoot(CommandGetXdbcTypeInfo
request, ResultSet typeInfo,
+ final BufferAllocator
allocator)
+ throws SQLException {
+ Objects.requireNonNull(allocator, "BufferAllocator cannot be null.");
+
+ VectorSchemaRoot root =
VectorSchemaRoot.create(Schemas.GET_TYPE_INFO_SCHEMA, allocator);
+
+ Map<FieldVector, String> mapper = new HashMap<>();
Review comment:
No, because it is using the FieldVector that are not static. They are
inputs.
Unfortunately, this is being used throughout the code. Because of this we've
created a task to refactor it and make it more elegant.
Is it ok for us to do this refactor in a different PR? Since this will
involve changes in other parts of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
