lidavidm commented on a change in pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#discussion_r815890993



##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc
##########
@@ -725,6 +725,27 @@ const Duration FloorTimePoint(const int64_t arg, const 
int64_t multiple,
   }
 }
 
+template <typename Duration, typename Unit, typename Localizer>

Review comment:
       nit: is there any point templating on Unit when it's apparently always 
`weeks` (and doesn't seem to make sense for any other unit)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to