pitrou commented on a change in pull request #12080:
URL: https://github.com/apache/arrow/pull/12080#discussion_r815918542
##########
File path: cpp/src/arrow/compute/exec.cc
##########
@@ -334,23 +334,20 @@ struct NullGeneralization {
if (datum.type()->id() == Type::NA) {
return ALL_NULL;
}
-
Review comment:
Note one might want to add:
```c++
if (!HasValidityBitmap(datum.type()->id())) {
return ALL_VALID;
}
```
This will only have an effect for union types, so not very important though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
