alamb commented on issue #1254: URL: https://github.com/apache/arrow-rs/issues/1254#issuecomment-1054584026
Sorry for the late reply @HaoYang670 > Lots of pub members are detected as dead code. I am not sure whether to clean them up. For example: If the code is dead I think we should remove it. One way for `pub` functions to be dead is if the module they are defined in is not `pub`. I am not sure how you are running clippy, but it may also be that some of these structs are only used when certain features of the `parquet` crate are enabled. I believe our CI system has good coverage so feel free to try removing them and if the CI passes I think it is a good change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
