alamb commented on a change in pull request #1334:
URL: https://github.com/apache/arrow-rs/pull/1334#discussion_r816205894
##########
File path: arrow/src/ffi.rs
##########
@@ -721,9 +721,11 @@ impl ArrowArray {
.to_string(),
));
};
+ let ffi_array = (*array).clone();
Review comment:
I am not super familiar with this code but it makes sense to me. The
clone here seems to just be a clone of the `FFI_ArrowArray` struct itself
(which is some ints and pointers) which seems reasonable enough to me.
If someone seems performance issues from this code, we can always add a
`try_from_raw_arc` or something, but this looks good to me for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
