alamb commented on a change in pull request #1367:
URL: https://github.com/apache/arrow-rs/pull/1367#discussion_r816277158
##########
File path: arrow/src/array/array_primitive.rs
##########
@@ -329,8 +330,53 @@ impl<'a, T: ArrowPrimitiveType> PrimitiveArray<T> {
}
}
-impl<T: ArrowPrimitiveType, Ptr: Borrow<Option<<T as
ArrowPrimitiveType>::Native>>>
- FromIterator<Ptr> for PrimitiveArray<T>
+#[derive(Debug)]
+pub struct ArrowPrimitiveTypeNative<T: ArrowPrimitiveType> {
Review comment:
```suggestion
struct ArrowPrimitiveTypeNative<T: ArrowPrimitiveType> {
```
I wonder if this needs to be `pub`?
If it does need to be pub I think we should probably document it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
