eitsupi commented on a change in pull request #12531:
URL: https://github.com/apache/arrow/pull/12531#discussion_r816880743
##########
File path: r/_pkgdown.yml
##########
@@ -40,60 +41,51 @@ navbar:
- articles
- news
- project
- right: github
+ right:
+ # - search # ARROW-15734
+ - github
components:
home:
text: ❯❯❯
href: https://arrow.apache.org/
- reference:
- text: Reference
- href: reference/index.html
project:
text: Project docs
menu:
- text: Specification
href: https://arrow.apache.org/docs/format/Columnar.html
- text: C GLib
- href: https://arrow.apache.org/docs/c_glib
+ href: https://arrow.apache.org/docs/c_glib/
- text: C++
- href: https://arrow.apache.org/docs/cpp
+ href: https://arrow.apache.org/docs/cpp/
- text: Java
- href: https://arrow.apache.org/docs/java
+ href: https://arrow.apache.org/docs/java/
- text: JavaScript
- href: https://arrow.apache.org/docs/js
+ href: https://arrow.apache.org/docs/js/
- text: Python
- href: https://arrow.apache.org/docs/python
+ href: https://arrow.apache.org/docs/python/
- text: R
- href: index.html
- articles:
- text: Articles
- menu:
- - text: Installing the Arrow Package on Linux
- href: articles/install.html
- - text: Working with Arrow Datasets and dplyr
- href: articles/dataset.html
- - text: Working with Cloud Storage (S3)
- href: articles/fs.html
- - text: Apache Arrow in Python and R with reticulate
- href: articles/python.html
- - text: Connecting to Flight RPC Servers
- href: articles/flight.html
- - text: Arrow R Developer Guide
- href: articles/developing.html
- - text: Developers
- menu:
- - text: Developer Environment Setup
- href: articles/developers/setup.html
- - text: Common Workflow Tasks
- href: articles/developers/workflow.html
- - text: Debugging
- href: articles/developers/debugging.html
- - text: Package Installation Details
- href: articles/developers/install_details.html
- - text: Docker
- href: articles/developers/docker.html
- - text: Writing Bindings
- href: articles/developers/bindings.html
+ href: https://arrow.apache.org/docs/r/
+
+articles:
+ - title: Usage
+ navbar: ~
+ contents:
+ - install
+ - dataset
+ - fs
+ - python
+ - flight
+ - title: Developers
+ navbar: Developers
+ contents:
+ - developing
+ - developers/setup
+ - developers/workflow
+ - developers/debugging
+ - developers/install_details
+ - developers/docker
+ - developers/bindings
Review comment:
As I mentioned in the body of the PR, this is the way pkgdown recommends
to list articles.
https://pkgdown.r-lib.org/reference/build_articles.html#index-and-navbar
https://github.com/r-lib/pkgdown/blob/ae7363faac9040a473a54fb3d770decdfb8dfec1/pkgdown/_pkgdown.yml#L33-L47
The settings before the change will not work with Bootstrap5.
(I don't understand the details, but it seems that the nav bar is broken
when there is a menu inside a menu.)
https://github.com/apache/arrow/blob/676b49f4f263a9bdcb7a48e434fa0d52f1da5dcd/r/_pkgdown.yml#L68-L84
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
