Johnnathanalmeida commented on a change in pull request #12526:
URL: https://github.com/apache/arrow/pull/12526#discussion_r817888587
##########
File path: cpp/src/gandiva/precompiled/arithmetic_ops.cc
##########
@@ -234,9 +234,13 @@ NUMERIC_TYPES(VALIDITY_OP, isnumeric, +)
#undef VALIDITY_OP
-#define IS_TRUE_OR_FALSE_BOOL(NAME, TYPE, OP) \
- FORCE_INLINE \
- gdv_##TYPE NAME##_boolean(gdv_##TYPE in) { return OP in; }
+#define IS_TRUE_OR_FALSE_BOOL(NAME, TYPE, OP) \
+ gdv_##TYPE NAME##_boolean(gdv_##TYPE in, gdv_boolean is_valid) { \
+ if (!is_valid) { \
Review comment:
I understood the logic of simplification and I removed the if clause.
But, I believe that the correct validation is without "!" character.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
