edponce commented on pull request #12460: URL: https://github.com/apache/arrow/pull/12460#issuecomment-1057577362
@lidavidm I agree. Also, a ScalarFunction should conform to [this iteration pattern](https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/codegen_internal.h#L610-L617), and cumulative sum does not, so it is a `VectorFunction`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
