cyb70289 edited a comment on pull request #12465: URL: https://github.com/apache/arrow/pull/12465#issuecomment-1057667955
I draw a diagram of server related classes based on my understanding. https://docs.google.com/spreadsheets/d/12D8psLE1o2NJEMRC4euU1C5r1QhE_7WV4F7TxZA4fwY/edit?usp=sharing  A big question is whether it's possible to remove `FlightServiceImpl` and move related code to `FlightServerBase::Impl`? And some nits: Can we mark `FlightServiceImpl` class as `final`? `service_` and `server_` members are not easy to follow throughout the code, what about renaming `FlightServiceImpl::base_` to `server_`, `FlightServerBase::Impl::server_` to `transport_`, `GrpcServerImpl` to `GrpcServerTransportImpl` (maybe member `service_` to `grpc_service`, `server_` to `grpc_server`)? Renaming `transport_server_impl.cc` to `transport_service_impl.cc`? As `FlightServerBase` and `FligthServiceImpl` can visit each other, does it make sense to remove `GrpcServiceHandler::service_`, leave only `server_`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
