yjshen commented on a change in pull request #1389:
URL: https://github.com/apache/arrow-rs/pull/1389#discussion_r818483222
##########
File path: parquet/src/file/serialized_reader.rs
##########
@@ -138,25 +138,51 @@ impl<R: 'static + ChunkReader> SerializedFileReader<R> {
})
}
- /// Filters row group metadata to only those row groups,
- /// for which the predicate function returns true
+ /// Filter row groups by metadata that match the predicate criteria and
row group's midpoint
+ /// are within the `[start, end)` range (if the range is provided).
pub fn filter_row_groups(
&mut self,
predicate: &dyn Fn(&RowGroupMetaData, usize) -> bool,
+ range: Option<(i64, i64)>,
Review comment:
I've considered an alternative to making this filter by range another
function while implementing this. But given the `filter_row_groups` here is not
idempotent, calling two separate methods one after another both filtering row
groups might be confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
