astrelsky commented on a change in pull request #12518:
URL: https://github.com/apache/arrow/pull/12518#discussion_r818591938
##########
File path: go/arrow/ipc/writer.go
##########
@@ -225,6 +225,7 @@ func (w *recordEncoder) compressBodyBuffers(p *Payload)
error {
defer cancel()
for i := 0; i < w.compressNP; i++ {
+ wg.Add(1)
Review comment:
> is there a uni test that can be added for this?
I took a quick look last night and it doesn't look like there are any test
for the exported `FileWriter`. I'm not super familiar with go and would prefer
to leave implementing tests for someone who knows what they are doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
