rdettai commented on pull request #1905: URL: https://github.com/apache/arrow-datafusion/pull/1905#issuecomment-1058087303
the API change you suggest here is not just a simplification, it breaks the way we can currently parallelize the ObjectStore. You are replacing `fn sync_reader(&self) -> Result<Box<dyn Read + Send + Sync>>` which takes an immutable ref and can thus be called in parallel from different threads into `fn set_limit(&mut self, limit: usize)` which requires an exclusive reference and a `Mutex` lock that blocks the entire `ObjectReader` at each operation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
