matthewmturner commented on pull request #1922: URL: https://github.com/apache/arrow-datafusion/pull/1922#issuecomment-1058877548
@alamb would you mind checking this out to see if going in right direction? I took the logic for writing csvs and put it in new function `plan_to_csv` within `src/physical_plan/file_format/csv` and moved testing there. Then just used that function in both `ExecutionContext` and `DataFrame` currently failing because of the signature of `write_csv` having `impl AsRef<str>` which i took from the existing implementation on `ExecutionContext` but doesnt work because trait object cant have method with generic type parameter. Is there a reason we cant use `&str`? More details here https://doc.rust-lang.org/error-index.html#E0038 and i dont think any of the proposed workarounds are good for our use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
