kszucs commented on a change in pull request #12320:
URL: https://github.com/apache/arrow/pull/12320#discussion_r819424282
##########
File path: dev/release/verify-release-candidate.sh
##########
@@ -481,98 +756,135 @@ test_ruby() {
popd
}
-test_go() {
- local VERSION=1.16.12
+test_csharp() {
+ show_header "Build and test C# libraries"
- local ARCH="$(uname -m)"
- if [ "$ARCH" == "x86_64" ]; then
- ARCH=amd64
- elif [ "$ARCH" == "aarch64" ]; then
- ARCH=arm64
- fi
+ install_csharp
- if [ "$(uname)" == "Darwin" ]; then
- local OS=darwin
+ pushd csharp
+
+ dotnet test
+
+ if [ "${SOURCE_KIND}" = "local" -o "${SOURCE_KIND}" = "git" ]; then
+ dotnet pack -c Release
else
- local OS=linux
+ mv dummy.git ../.git
+ dotnet pack -c Release
+ mv ../.git dummy.git
fi
- local GO_ARCHIVE=go$VERSION.$OS-$ARCH.tar.gz
- wget https://dl.google.com/go/$GO_ARCHIVE
+ sourcelink test
artifacts/Apache.Arrow/Release/netstandard1.3/Apache.Arrow.pdb
+ sourcelink test artifacts/Apache.Arrow/Release/netcoreapp2.1/Apache.Arrow.pdb
+
+ popd
+}
- mkdir -p local-go
- tar -xzf $GO_ARCHIVE -C local-go
- rm -f $GO_ARCHIVE
+test_js() {
+ show_header "Build and test JavaScript libraries"
- export GOROOT=`pwd`/local-go/go
- export GOPATH=`pwd`/local-go/gopath
- export PATH=$GOROOT/bin:$GOPATH/bin:$PATH
+ setup_nodejs || exit 1
+ setup_conda nodejs=17 || exit 1
Review comment:
I'm updating the name of the setup functions because they are mutually
exclusive. Here it means that either install nodejs by downloading it or if we
are in a conda environment then install the conda package instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
