lidavidm commented on a change in pull request #12560:
URL: https://github.com/apache/arrow/pull/12560#discussion_r819727129
##########
File path: cpp/src/arrow/dataset/scanner.cc
##########
@@ -877,6 +882,15 @@ Result<compute::ExecNode*> MakeScanNode(compute::ExecPlan*
plan,
batch->values.emplace_back(partial.fragment.index);
batch->values.emplace_back(partial.record_batch.index);
batch->values.emplace_back(partial.record_batch.last);
+
+ auto filefragment_casted =
+ dynamic_cast<const FileFragment*>(partial.fragment.value.get());
+ if (filefragment_casted != nullptr) {
+ batch->values.emplace_back(filefragment_casted->source().path());
+ } else {
+ batch->values.emplace_back("");
Review comment:
Sorry - I meant that you could use ToString for the case where it's not
a file fragment. For a file fragment it makes sense to get the path directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
