westonpace commented on a change in pull request #12564:
URL: https://github.com/apache/arrow/pull/12564#discussion_r819788630
##########
File path: r/src/compute-exec.cpp
##########
@@ -277,4 +278,65 @@ std::shared_ptr<compute::ExecNode>
ExecNode_ReadFromRecordBatchReader(
return MakeExecNodeOrStop("source", plan.get(), {}, options);
}
+// just until we figure out the incantation to get a proper sinknode
Review comment:
I think we would eventually want to do the same thing we do with exec
plans which is to consume with pushgenerator (which is basically a
producer/consumer queue). The sink node consumer will push the batch into the
queue and then a record batch reader will read the batches from the queue.
We'd also want to wire it up to backpressure like we have today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
