houqp commented on a change in pull request #1929:
URL: https://github.com/apache/arrow-datafusion/pull/1929#discussion_r820142824
##########
File path: datafusion-jit/src/jit.rs
##########
@@ -51,6 +52,28 @@ impl Default for JIT {
module,
}
}
+
+ #[cfg(target_arch = "aarch64")]
+ fn default() -> Self {
+ let mut flag_builder = settings::builder();
+ // On at least AArch64, "colocated" calls use shorter-range
relocations,
+ // which might not reach all definitions; we can't handle that here, so
+ // we require long-range relocation types.
+ flag_builder.set("use_colocated_libcalls", "false").unwrap();
+ flag_builder.set("is_pic", "false").unwrap();
Review comment:
perhaps worth linking to
https://github.com/bytecodealliance/wasmtime/issues/2907 in the comment so we
know to reenable pic when it's supported upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
