HaoYang670 edited a comment on issue #1400:
URL: https://github.com/apache/arrow-rs/issues/1400#issuecomment-1059951540


   > I'm now actually a bit worried about the correctness of the nullable 
version, I don't see `has_value` being used apart from the assignment, if that 
flag is false then the result should be `None`.
   
   There is at least one valid value in the array. Because we have tested `all 
nulls array` before:
   ```rust
   if null_count == array.len() {
           return None;
   }
   ```
   
https://github.com/apache/arrow-rs/blob/master/arrow/src/compute/kernels/aggregate.rs#L107-L109


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to