emkornfield commented on a change in pull request #12574:
URL: https://github.com/apache/arrow/pull/12574#discussion_r820256307
##########
File path: cpp/src/arrow/csv/writer.cc
##########
@@ -136,15 +134,14 @@ class ColumnPopulator {
MemoryPool* const pool_;
};
-// Copies the contents of to out properly escaping any necessary characters.
-// Returns the position prior to last copied character (out_end is
decremented).
-char* EscapeReverse(arrow::util::string_view s, char* out_end) {
- for (const char* val = s.data() + s.length() - 1; val >= s.data(); val--,
out_end--) {
- if (*val == '"') {
- *out_end = *val;
- out_end--;
+// Copies the contents of s to out properly escaping any necessary characters.
+// Returns the position next to last copied character.
+char* Escape(arrow::util::string_view s, char* out_end) {
+ for (const char c : s) {
Review comment:
It occurs to me that performance here might be improved by using higher
level methods to find the next escape character and memcpy in between.
Probably depends on string lengths being processed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
