baumgold commented on pull request #277: URL: https://github.com/apache/arrow-julia/pull/277#issuecomment-1060041996
> I left a few comments on tweaks to make. It looks like the 2 main things needed here are some `Arrow.Writer`-specific tests (I'd recommend adding a new `@testset` in the runtests.jl file, or adding a new file of tests all together), and adding some documentation (You can add "in code" docs attached to the `Writer` struct directly which will get included in the auto-docs generation, and it would also be helpful to add a section to the manual, somewhere around [here](https://github.com/apache/arrow-julia/blob/main/docs/src/manual.md#writing-arrow-data)). Thanks for your review. I've addressed your comments in my most recent commit. I'll add some tests and documentation shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
