yjshen commented on a change in pull request #1933:
URL: https://github.com/apache/arrow-datafusion/pull/1933#discussion_r820319899
##########
File path: datafusion/src/execution/memory_manager.rs
##########
@@ -340,6 +340,9 @@ impl MemoryManager {
} else if current < min_per_rqt {
// if we cannot acquire at lease 1/2n memory, just wait for
others
// to spill instead spill self frequently with limited total
mem
+ debug!(
+ "Cannot acquire minimum amount of memory {}, waiting for
others to spill ...",
+ human_readable_size(min_per_rqt));
Review comment:
One more thought, based on your measure timing comments above, probably
we could `warn!` if we've waited for a longer time than some threshold? In case
reproducing the race would be hard. `debug!` at the first round might not be
revealed in the first place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
