yahoNanJing commented on a change in pull request #1912: URL: https://github.com/apache/arrow-datafusion/pull/1912#discussion_r820380702
########## File path: ballista/rust/scheduler/src/scheduler_server/event_loop.rs ########## @@ -0,0 +1,138 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::sync::Arc; +use std::time::Duration; + +use async_trait::async_trait; +use log::{debug, warn}; + +use ballista_core::error::{BallistaError, Result}; +use ballista_core::event_loop::EventAction; +use ballista_core::serde::protobuf::{LaunchTaskParams, TaskDefinition}; +use ballista_core::serde::scheduler::ExecutorData; +use ballista_core::serde::{AsExecutionPlan, AsLogicalPlan}; + +use crate::scheduler_server::task_scheduler::TaskScheduler; +use crate::scheduler_server::ExecutorsClient; +use crate::state::SchedulerState; + +pub(crate) enum SchedulerServerEvent { + JobSubmitted(String), +} + +pub(crate) struct SchedulerServerEventAction< + T: 'static + AsLogicalPlan, + U: 'static + AsExecutionPlan, +> { + state: Arc<SchedulerState<T, U>>, + executors_client: ExecutorsClient, +} + +impl<T: 'static + AsLogicalPlan, U: 'static + AsExecutionPlan> + SchedulerServerEventAction<T, U> +{ + pub fn new( + state: Arc<SchedulerState<T, U>>, + executors_client: ExecutorsClient, + ) -> Self { + Self { + state, + executors_client, + } + } + + async fn offer_resources( + &self, + job_id: String, + ) -> Result<Option<SchedulerServerEvent>> { + let mut available_executors = self.state.get_available_executors_data(); + // In case of there's no enough resources, reschedule the tasks of the job + if available_executors.is_empty() { + // TODO Maybe it's better to use an exclusive runtime for this kind task scheduling + warn!("Not enough available executors for task running"); + tokio::time::sleep(Duration::from_millis(100)).await; + return Ok(Some(SchedulerServerEvent::JobSubmitted(job_id))); + } + + let (tasks_assigment, num_tasks) = self + .state + .fetch_tasks(&mut available_executors, &job_id) + .await?; + if num_tasks > 0 { + self.launch_tasks(&available_executors, tasks_assigment) + .await?; + } + + Ok(None) + } + + async fn launch_tasks( + &self, + executors: &[ExecutorData], + tasks_assigment: Vec<Vec<TaskDefinition>>, + ) -> Result<()> { + for (idx_executor, tasks) in tasks_assigment.into_iter().enumerate() { + if !tasks.is_empty() { + let executor_data = &executors[idx_executor]; + debug!( + "Start to launch tasks {:?} to executor {:?}", + tasks, executor_data.executor_id + ); + let mut client = { + let clients = self.executors_client.read().await; + clients.get(&executor_data.executor_id).unwrap().clone() + }; + // Update the resources first + self.state.save_executor_data(executor_data.clone()); + // TODO check whether launching task is successful or not + client.launch_task(LaunchTaskParams { task: tasks }).await?; + } else { + // Since the task assignment policy is round robin, + // if find tasks for one executor is empty, just break fast + break; + } + } + + Ok(()) + } +} + +#[async_trait] +impl<T: 'static + AsLogicalPlan, U: 'static + AsExecutionPlan> + EventAction<SchedulerServerEvent> for SchedulerServerEventAction<T, U> +{ + // TODO + fn on_start(&self) {} Review comment: Here, the reason not to use todo!() is to avoid panic. The reason to add TODO comments is for future error handling or other things to make the whole system more robust. If it makes confusing, we can just remove them currently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
