alamb commented on pull request #1386: URL: https://github.com/apache/arrow-rs/pull/1386#issuecomment-1060608164
> [As you may have noted, I implement an example in https://github.com/wangfenjin/arrow-datafusion/pull/1 (we need to publish a new version then I can create MR to the arrow-datafusion repo). For the integration test, not sure if we need to implement it in [this](https://github.com/apache/arrow-rs/blob/master/arrow-flight/examples/server.rs) repo? Because if we implement one like this seems useless, and if we want to implement a useful example, we'd better depends on arrow-datafusion as we need a SQL server.](https://github.com/apache/arrow-rs/pull/1386#issuecomment-1059971584) I actually think both types of examples are useful, but for different purposes: 1. Example just in arrow-flight (no actual SQL implementation) such as [this](https://github.com/apache/arrow-rs/blob/master/arrow-flight/examples/server.rs): helps users of arrow-flight who will not be using datafusion something to start with that compiles so they can plug in their own implementation that without having to cut out datafusion specific stuff 2. Example in datafusion such as [this](https://github.com/wangfenjin/arrow-datafusion/pull/1): Shows a real end to end use of flight sql and how one system connects it together The example in arrow can be done as a follow on PR (maybe someone else will do it) -- I'll plan to file tickets for follow on work after your initial PR Thanks again @wangfenjin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
