lidavidm commented on a change in pull request #11982:
URL: https://github.com/apache/arrow/pull/11982#discussion_r820729600
##########
File path: format/FlightSql.proto
##########
@@ -867,6 +867,185 @@ enum SqlSupportsConvert {
SQL_CONVERT_VARCHAR = 19;
}
+/**
+ * It is an attribute that identifies the type of any object. It's
+ * used by JDBC and ODBC to expose the values defined by the DBMC.
+ */
+enum XDBCDataType {
+ XDBC_TYPE_UNKNOWN_TYPE = 0;
+ XDBC_TYPE_CHAR = 1;
+ XDBC_TYPE_NUMERIC = 2;
+ XDBC_TYPE_DECIMAL = 3;
+ XDBC_TYPE_INTEGER = 4;
+ XDBC_TYPE_SMALLINT = 5;
+ XDBC_TYPE_FLOAT = 6;
+ XDBC_TYPE_REAL = 7;
+ XDBC_TYPE_DOUBLE = 8;
+ XDBC_TYPE_DATETIME = 9;
+ XDBC_TYPE_INTERVAL = 10;
+ XDBC_TYPE_VARCHAR = 12;
+ XDBC_LONGVARCHAR = -1;
+ XDBC_BINARY = -2;
+ XDBC_VARBINARY = -3;
+ XDBC_LONGVARBINARY = -4;
+ XDBC_BIGINT = -5;
+ XDBC_TINYINT = -6;
+ XDBC_BIT = -7;
+ XDBC_WCHAR = -8;
+ XDBC_WVARCHAR = -9;
Review comment:
Was this addressed? Maybe each value should have a doc comment noting
the JDBC/ODBC equivalent, or at least, the enum-level docstring should note
that each of these values corresponds to a value from those standards?
##########
File path: format/FlightSql.proto
##########
@@ -867,6 +867,167 @@ enum SqlSupportsConvert {
SQL_CONVERT_VARCHAR = 19;
}
+enum SqlDataType {
+ SQL_TYPE_UNKNOWN_TYPE = 0;
+ SQL_TYPE_CHAR = 1;
+ SQL_TYPE_NUMERIC = 2;
+ SQL_TYPE_DECIMAL = 3;
+ SQL_TYPE_INTEGER = 4;
+ SQL_TYPE_SMALLINT = 5;
+ SQL_TYPE_FLOAT = 6;
+ SQL_TYPE_REAL = 7;
+ SQL_TYPE_DOUBLE = 8;
+ SQL_TYPE_DATETIME = 9;
+ SQL_TYPE_INTERVAL = 10;
+ SQL_TYPE_VARCHAR = 12;
+}
+
+enum SqlDatetimeSubcode {
+ option allow_alias = true;
Review comment:
I'm not sure this is resolved - if JDBC/ODBC use the same value for
different concepts, shouldn't we have separate values for them? For instance,
if a Flight SQL server wants to return XDBC_SUBCODE_DATE, how is it supposed to
know whether the client will interpret it as DATE or YEAR?
If they are just different names for the same concept, we should pick just
one name and perhaps document the correspondence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
