rok commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r821026178
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -3403,15 +3403,32 @@ macro(build_absl_once)
set_property(TARGET absl::throw_delegate
PROPERTY INTERFACE_LINK_LIBRARIES absl::config
absl::raw_logging_internal)
- set_property(TARGET absl::time
- PROPERTY INTERFACE_LINK_LIBRARIES
- absl::base
- absl::civil_time
- absl::core_headers
- absl::int128
- absl::raw_logging_internal
- absl::strings
- absl::time_zone)
+ if(APPLE)
+ # This is due to upstream absl::cctz issue
+ # https://github.com/abseil/abseil-cpp/issues/283
+ find_library(CoreFoundation CoreFoundation)
+ set_property(TARGET absl::time
+ PROPERTY INTERFACE_LINK_LIBRARIES
+ absl::base
+ absl::civil_time
+ absl::core_headers
+ absl::int128
+ absl::raw_logging_internal
+ absl::strings
+ absl::time_zone
+ ${CoreFoundation})
+ else()
+ find_library(CoreFoundation CoreFoundation)
Review comment:
I'm not sure about absl::time's deps on non-Apple so leaving that branch
as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
