dragosmg commented on a change in pull request #12482:
URL: https://github.com/apache/arrow/pull/12482#discussion_r821815217
##########
File path: r/R/dplyr-funcs-datetime.R
##########
@@ -105,17 +105,39 @@ register_bindings_datetime <- function() {
(call_binding("yday", x) - 1) %/% 7 + 1
})
- register_binding("month", function(x, label = FALSE, abbr = TRUE, locale =
Sys.getlocale("LC_TIME")) {
+ register_binding("month", function(x,
+ label = FALSE,
+ abbr = TRUE,
+ locale = Sys.getlocale("LC_TIME")) {
+
+ if (call_binding("is.integer", x)) {
+ x <- call_binding("if_else",
+ call_binding("between", x, 1, 12),
+ x,
+ NA_integer_)
+ if (!label) {
+ # if we don't need a label we can return the integer itself
(constrained
+ # to 1:12)
+ return(x)
+ } else {
+ # make the integer into a date32() - which interprets integers as
+ # days from epoch (we multiply by 28 to be able to later extract the
+ # month with label) - NB this builds a false date (to be used by
strftime)
+ # since we only know and care about the month
+ x <- build_expr("cast", x * 28L, options = cast_options(to_type =
date32()))
+ }
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
