sanjibansg commented on a change in pull request #12530:
URL: https://github.com/apache/arrow/pull/12530#discussion_r821919339
##########
File path: cpp/src/arrow/dataset/dataset_writer.cc
##########
@@ -326,9 +336,14 @@ class DatasetWriterDirectoryQueue : public
util::AsyncDestroyable {
uint64_t rows_written() const { return rows_written_; }
- void PrepareDirectory() {
- init_future_ =
DeferNotOk(write_options_.filesystem->io_context().executor()->Submit(
- [this]() { return write_options_.filesystem->CreateDir(directory_);
}));
+ void PrepareDirectory(std::string& prefix) {
+ if (prefix.empty()) {
Review comment:
Made the change. Yes, we may need to have custom partitioning having
both prefix and directory in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
