cyb70289 commented on a change in pull request #12579:
URL: https://github.com/apache/arrow/pull/12579#discussion_r822247547
##########
File path: cpp/src/arrow/array/builder_primitive.h
##########
@@ -146,6 +146,11 @@ class NumericBuilder : public ArrayBuilder {
return reinterpret_cast<value_type*>(data_builder_.mutable_data())[index];
}
+ void UnsafeSetIsNull(int64_t index, bool is_null) {
+ this->operator[](index) = value_type{};
Review comment:
It may cause surprise if this api always clears an existing slot
implicitly, even if we valid-fy a valid slot, which I suppose should have no
side effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
