mingmwang commented on a change in pull request #1924:
URL: https://github.com/apache/arrow-datafusion/pull/1924#discussion_r823286069
##########
File path: ballista/rust/scheduler/src/lib.rs
##########
@@ -1001,10 +1103,56 @@ mod test {
namespace.to_string(),
BallistaCodec::default(),
);
- let ctx = scheduler.ctx.read().await;
- state.init(&ctx).await?;
+ state.init().await?;
// executor should be registered
assert_eq!(state.get_executors_metadata().await.unwrap().len(), 1);
Ok(())
}
}
+
+/// A Registry holds all the datafusion session contexts
+pub struct SessionContextRegistry {
Review comment:
Hi @thinkharderdev
Yes, this is very good point. In the current implementation, the
SessionContext is alway created using configurations from query
settings/Ballista configurations, there is no way to configure different
optimizers/planners. Maybe I can add a new struct like Base SessionContext
Builder and make that an extension point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
