dragosmg commented on a change in pull request #12506:
URL: https://github.com/apache/arrow/pull/12506#discussion_r823610428
##########
File path: r/R/dplyr-funcs-type.R
##########
@@ -120,6 +120,42 @@ register_bindings_type_cast <- function() {
}
build_expr("cast", x, options = cast_options(to_type = date32()))
})
+ register_binding("as.difftime", function(x,
Review comment:
I was under the impression the coercion functions (`as.*()`) lived in
_dplyr-funcs-type.R_. More than happy to move it to _...-datetime.R_ if that is
more intuitive.
##########
File path: r/R/dplyr-funcs-type.R
##########
@@ -120,6 +120,42 @@ register_bindings_type_cast <- function() {
}
build_expr("cast", x, options = cast_options(to_type = date32()))
})
+ register_binding("as.difftime", function(x,
Review comment:
If we think _...-datetime.R_ is a better location I should probably move
the `as.Date` binding there too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
