alamb edited a comment on pull request #1914:
URL:
https://github.com/apache/arrow-datafusion/pull/1914#issuecomment-1063984916
@jiacai2050 sadly another clippy issue has cropped up
I think it is related to serializing the schema in ballista (which actually
doesn't preserve the metadata)
Is suggest a fix like the following, and file a ticket for the fact that
ballista serialization doesn't preserve metadata.
I can file if it you would like
```diff
diff --git a/datafusion-proto/src/from_proto.rs
b/datafusion-proto/src/from_proto.rs
index d589ef388..2bf65d4db 100644
--- a/datafusion-proto/src/from_proto.rs
+++ b/datafusion-proto/src/from_proto.rs
@@ -155,6 +155,7 @@ impl TryFrom<&protobuf::DfSchema> for DFSchema {
.iter()
.map(|c| c.try_into())
.collect::<Result<Vec<DFField>, _>>()?;
+ #[allow(deprecated)]
Ok(DFSchema::new(fields)?)
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
