rok commented on pull request #12154: URL: https://github.com/apache/arrow/pull/12154#issuecomment-1064095547
That's great news @djnavarro! Does solving this with subtraction work correctly around DST changes? e.g. (stealing [an example from here](https://github.com/HowardHinnant/date/wiki/Examples-and-Recipes#datetime-interpreted-as-coming-from-a-specific-time-zone-to-time_point)): ``` 2018-03-25 02:10:00 is in a gap between 2018-03-25 02:00:00 CET and 2018-03-25 03:00:00 CEST which are both equivalent to 2018-03-25 01:00:00 UTC ``` We should also consider performance implications here. Adding an option to the c++ kernels might be better than calling two different c++ kernels. However that should be a separate ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
