tustvold commented on a change in pull request #1418:
URL: https://github.com/apache/arrow-rs/pull/1418#discussion_r823823785
##########
File path: parquet/src/encodings/encoding.rs
##########
@@ -581,6 +581,13 @@ impl<T: DataType> DeltaBitPackEncoder<T> {
// values left
let n = cmp::min(self.mini_block_size, self.values_in_block);
if n == 0 {
+ // Decoders should be agnostic to the padding value, we
therefore use 0xFF
Review comment:
This is the fix for #1416, I opted to pad with a non-zero value for
tests so we have coverage of that scenario, but not produce such data outside
of tests for better ecosystem-interop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
