jhorstmann opened a new pull request #1421:
URL: https://github.com/apache/arrow-rs/pull/1421
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #1410.
# Rationale for this change
Changes the `push`, `push_unchecked` and `extend_from_iter` functions so
that data is transfered using `copy_nonoverlapping` which works for unaligned
destinations. LLVM will most likely transform this again into a single
unaligned write. This also makes these methods actually use the `ToByteSlice`
trait. In `extend_from_slice`, which this PR did not change, the trait is more
used like a marker trait because the whole slice is copied without going
through the trait methods. This is probably fine since it's supposed to be an
internal trait that is only implemented for `ArrowNativeType`.
All newly added tests were previously failing when running under miri.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
