vibhatha commented on a change in pull request #12113:
URL: https://github.com/apache/arrow/pull/12113#discussion_r823933696
##########
File path: r/R/dplyr-collect.R
##########
@@ -103,10 +104,37 @@ implicit_schema <- function(.data) {
if (!is.null(.data$join) && !(.data$join$type %in% JoinType[1:4])) {
# Add cols from right side, except for semi/anti joins
right_cols <- .data$join$right_data$selected_columns
- new_fields <- c(new_fields, map(
+ left_cols <- .data$selected_columns
+ right_fields <- map(
right_cols[setdiff(names(right_cols), .data$join$by)],
~ .$type(.data$join$right_data$.data$schema)
- ))
+ )
+ # get right table and left table column names excluding the join key
+ right_cols_ex_by <- right_cols[setdiff(names(right_cols), .data$join$by)]
+ left_cols_ex_by <- left_cols[setdiff(names(left_cols), .data$join$by)]
+ # find the common column names in left and right tables
+ common_cols <- intersect(names(right_cols_ex_by), names(left_cols_ex_by))
+
+ # helper method to add suffix
+ add_suffix <- function(fields, common_cols, suffix) {
Review comment:
Sure @jonkeane we can make that change. I originally wrote it that way,
since it may not be used I put it into the call. But I can extract it and add a
few test cases. That sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
