realno commented on pull request #1935: URL: https://github.com/apache/arrow-datafusion/pull/1935#issuecomment-1064660949
> These PRs basically does not change behaviors. Therefore, I didn't add additional unit tests. Yes, unit test for this PR is good. My comment was more general to Ballista overall, sorry didn't make that clear :) > For the pipeline, I'm not so sure whether the Ballista integration test be added or not. I checked the pipeline definition the integration test is not part of it. I think at some point we should include it. @andygrove @alamb should we do that now? I guess one concern might be if we want it to block the whole DataFusion pipeline -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
