yahoNanJing commented on a change in pull request #1983:
URL: https://github.com/apache/arrow-datafusion/pull/1983#discussion_r824447420
##########
File path: ballista/rust/scheduler/src/scheduler_server/event_loop.rs
##########
@@ -50,32 +47,53 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan>
pub fn new(
state: Arc<SchedulerState<T, U>>,
executors_client: ExecutorsClient,
+ is_test: bool,
) -> Self {
Self {
state,
executors_client,
+ is_test,
}
}
- async fn offer_resources(
- &self,
- job_id: String,
- ) -> Result<Option<SchedulerServerEvent>> {
- let mut available_executors =
self.state.get_available_executors_data();
+ async fn offer_resources(&self, n: u32) ->
Result<Option<SchedulerServerEvent>> {
+ let mut available_executors = if self.is_test {
Review comment:
It's not just the heartbeat issue. For Push-based task scheduling, the
schedule will launch tasks to the corresponding executors which should start up
the GRPC service. It's a bit too heavy for the unit test.
##########
File path: ballista/rust/scheduler/src/scheduler_server/event_loop.rs
##########
@@ -50,32 +47,53 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan>
pub fn new(
state: Arc<SchedulerState<T, U>>,
executors_client: ExecutorsClient,
+ is_test: bool,
) -> Self {
Self {
state,
executors_client,
+ is_test,
}
}
- async fn offer_resources(
- &self,
- job_id: String,
- ) -> Result<Option<SchedulerServerEvent>> {
- let mut available_executors =
self.state.get_available_executors_data();
+ async fn offer_resources(&self, n: u32) ->
Result<Option<SchedulerServerEvent>> {
+ let mut available_executors = if self.is_test {
Review comment:
It's not just the heartbeat issue. For Push-based task scheduling, the
schedule will launch tasks to the corresponding executors which should start up
the GRPC service. It's a bit too heavy for a unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
